From: "Morrison, John" <[EMAIL PROTECTED]> > > From: Gerhard Froehlich [mailto:[EMAIL PROTECTED]] > > >I think that we already have this. It is the duty of the > > >committer to undertake initial quality control when they > > >accept the patch from Bugzilla and prepare for their > > >commit. If they do not know anything about the topic, then > > >they should not be taking on the patch - let someone else > > >do it. > > > > Who is someone else? Patches in bugzilla are very lonely in > > the moment. There are simply not applied. Why? Because there > > about 600 classes in Cocoon, about 10 active committers and > > nobody feels responsible. It's easy to say, oh I didn't > > wrote this code, therefor I can't apply this patch. But > > patches like NPE fixes, can be applied by every committer, I > > swear! > > Good point. Head is unstable so what do people think; have a > blitz and apply all the patches that can be? If a patch can't > be applied mark it as needing updated?
Maybe it's better to have separate prefixes for additions and real patches? Say: [ADD] - for absolutely new functionality contribution [PATCH] - for fixing real bugs Konstantin > > J. > > > ======================================================================= > Information in this email and any attachments are confidential, and may > not be copied or used by anyone other than the addressee, nor disclosed > to any third party without our permission. There is no intention to > create any legally binding contract or other commitment through the use > of this email. > > Experian Limited (registration number 653331). > Registered office: Talbot House, Talbot Street, Nottingham NG1 5HF > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, email: [EMAIL PROTECTED] > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, email: [EMAIL PROTECTED]