Geoff Howard wrote: > Vadim wrote: > >Geoff Howard wrote: > >>Vadim wrote: > >>>Geoff Howard wrote: > >>>> ### wrote: > >>>>>Unfortunately, when validate-jars was put back in, an override mechanism > >>>>>wasn't added so you're stuck manually editing the build file for now. > >>>>> > >>>>>I'll be submitting a patch to first of all add the override mechanism so > >>>>>that this won't trip people up until the target is fixed. > >>> > >>>Umm... I fear I fixed the reason of the issue... I haven't change build > >>>to make validation optional - this will keep document more up-to-date. > >>> > >>>Vadim > >> > >> > >>Shouldn't the jars validation be configurable though like the other > >>validations? If it's now working, just default the validate.jars to true > >>by default. > > > >Ok, so you will add it by yourself then ;-P
I think that the validate-jars/check-jars task should *not* be optional. The only reason that it might fail and bust the build is if the committer who added the new jar did not describe it properly (or did not do a build before committing). The reason for this task is to ensure a solid build. > almost forgot! :) (If I don't tick anybody off soon - the vote is still > going on) Well now you can "tick people off" to your heart's content. Be kind please. --David
