Christopher Oliver wrote:
FlowVelocityGenerator to replace VelocityGenerator
-1 to replacing: FlowVelocityGenerator introduces dependencies on org.apache.commons.jxpath and org.mozilla.javascript which where missing in original VelocityGenerator.
Why is that a problem?
Also, does it support functionality which is present in original VelocityGenerator? I can make out of the diff that "objectExports" are completely gone, and I'm not sure whether other features are still there or they have changed.
I'm +1 on extending VelocityGenerator but not at expense of breaking compatibility. I.e., it should not be hard to include couple of more objects in velocity context -- flowmap and continuation; and session too -- but preferably this should be done without introducing new dependencies or breaking existing templates our users may have.
Vadim
I agree that backwards compatibilty should be maintained. I don't see why it should be a problem to do that.
Sorry, but I don't agree with your design on extending VelocityGenerator, however.
Stefano Mazzocchi wrote:
Here is what I propose to move:
1) ImageReader 2) Paginator 3) JXTemplate*
anything else?
