Nuno,

please submit the patch via Bugzilla.
I will gladly review and apply if appropriate.

Thank you.

Ivelin


----- Original Message -----
From: "Nuno Santos" <[EMAIL PROTECTED]>
To: <[EMAIL PROTECTED]>
Sent: Tuesday, October 15, 2002 6:52 AM
Subject: XMLForm transformer


When i was developing a multi edit form, using the xf:repeat tag, i
realised that it didn´t work before a simple tag call before, like
"count(*)".

I then checked the source code and found the function that's responsible
for the Repeat tag unrolling :
"protected void unrollRepeatTag( DocumentFragment docFragment )throws
SAXException"

inside the function i found a block wich is responsible to get all the
possible locations inside the «nodeset»:
" Collection locations = currentForm.locate( nodeset );"
" Iterator iter = locations.iterator();"
" while ( iter.hasNext() ){"
"   String nextNodeLocation = (String) iter.next ();"

after expanding the location to a group, there is also a condition
check, which in point of view is unneeded:
"if (value_ != null)"


is say it because there is no previous "value_" setting if our top tag
is "xf:repeat", wich means that we need to access a simple tag before
using the "xf:repeat".

My sugestion is that eather remove the check (that i think is undeed) or
replace it for a condition check on the group location object "
Form.getvalue(nextNodeLocation)!=null"



                                            Best regards
                                                Nuno Santos



---------------------------------------------------------------------
Please check that your question  has not already been answered in the
FAQ before posting.     <http://xml.apache.org/cocoon/faq/index.html>

To unsubscribe, e-mail:     <[EMAIL PROTECTED]>
For additional commands, e-mail:   <[EMAIL PROTECTED]>



---------------------------------------------------------------------
Please check that your question  has not already been answered in the
FAQ before posting.     <http://xml.apache.org/cocoon/faq/index.html>

To unsubscribe, e-mail:     <[EMAIL PROTECTED]>
For additional commands, e-mail:   <[EMAIL PROTECTED]>

Reply via email to