On Fri, Apr 22, 2016 at 07:40:00PM +0200, u-m...@aetey.se wrote: > On Fri, Apr 22, 2016 at 11:55:46AM -0400, Jan Harkes wrote: > > I can't believe this was the only place that had an alignment problem > > like this, those ioctls are badly packed all over the place. > > May be we are especially lucky, but this was the only visible problem.
This particular VIOC_GETVOLSTAT pioctl call is used in 4 different places in cfs and 2 places in repair, your fix addressed one place. Also things like the pioctl in/out structures seem to be defined at the spot of the implementation which makes it very easy to make a change somewhere that is not picked up elsewhere. Considering how many places need to change I'm no longer sure I want to reshuffle and am starting to think that having common pioctl pack/unpack functions in a shared place might be a better approach. Going to have to ponder this a bit. Jan
