Re: Venus crashes after mkdir on Linux

[jaharkes]

[EMAIL PROTECTED] said:
| But when I try to create a subdir (in the root-Volume or some other
| volumes) the "venus -init" crashes

Hi Jakob,

I think the following patch might help, Bob had a similar crash, which
was caused by an uninitialized variable, which this patch fixes.


| After having some problems with the compilation:
| Makeconf.linux: -lncurses was missing for -lreadline

Hmm, that would be -lncurses, or -ltermcap depending on what the OS 
provides. Don't know how to specify that in the configure.in yet.

| lwp.c: added "typedef unsigned long register_t;" 

Could test for that, but I might just as well replace all register_t
with unsigned int, they are only used on i386.

l8r,
        Jan

Index: coda/coda-src/venus/vproc_pathname.cc
diff -c coda/coda-src/venus/vproc_pathname.cc:4.13 
coda/coda-src/venus/vproc_pathname.cc:4.14
*** coda/coda-src/venus/vproc_pathname.cc:4.13  Thu Mar  4 22:52:57 1999
--- coda/coda-src/venus/vproc_pathname.cc       Thu Mar 25 21:16:37 1999
***************
*** 412,419 ****
  
  void vproc::verifyname(char *name, int flags)
  {
!     char *ptr;
!     int   length = strlen(name);
  
      /* Disallow '.', '..', and '/' */
      if (flags & NAME_NO_DOTS)
--- 412,418 ----
  
  void vproc::verifyname(char *name, int flags)
  {
!     int length = strlen(name);
  
      /* Disallow '.', '..', and '/' */
      if (flags & NAME_NO_DOTS)
***************
*** 444,450 ****
      }
  
      /* Disallow names ending in anything like "@sys/@cpu" (@???). */
!     if ((flags & NAME_NO_EXPANSION) && (length >= 4) && (ptr[length-4] == '@'))
      {
        u.u_error = EINVAL;
        return;
--- 443,449 ----
      }
  
      /* Disallow names ending in anything like "@sys/@cpu" (@???). */
!     if ((flags & NAME_NO_EXPANSION) && (length >= 4) && (name[length-4] == '@'))
      {
        u.u_error = EINVAL;
        return;