On 12 janvier 19:04, Carl Crowder wrote: > I think the point is that Pylint does not only say "this is wrong", but also > says "are you sure this is right?". These things are usually warnings but > perhaps 'code smell' is a better name. Because, in this case, the 'else' > isn't strictly necessary, Pylint (correctly, in my opinion) raises a warning > which effectively says "This 'else' clause does not actually need to be there > - did you do it on purpose, or have some break statements been refactored > away or something?". I consider it more like a code review, in which the > reviewer tentatively asks "this looks odd - is it deliberate?" simply to > verify in case it was not. > > It's pretty easy to suppress the warning either on this line alone or on the > entire project if this is your code style, so I prefer the case where Pylint > catches a real error but may be to hasty for some users. I think Pylint > should be regarded as producing both actual errors as output but also > advisories and questions.
That's exactly the point: pylint does only tell you "buddy, there may be here something weird or/and that could be written differently", and that's perfectly fine to shut him down if you feel it's ok. -- Sylvain Thénault, LOGILAB, Paris (01.45.32.03.12) - Toulouse (05.62.17.16.42) Formations Python, Debian, Méth. Agiles: http://www.logilab.fr/formations Développement logiciel sur mesure: http://www.logilab.fr/services CubicWeb, the semantic web framework: http://www.cubicweb.org _______________________________________________ code-quality mailing list code-quality@python.org https://mail.python.org/mailman/listinfo/code-quality
