Sorry but I don't understand what ou are saying here. I probably did not explain clearly enaugh the changes I am proposing. I think submiting a pull request would be easier than trying to explain in detail (I would do it as soon as my previous pull request is reviewed). Anyway I compilled with my changes for JavaSE and Android and did not see any issue so far. However, I have a few questions: - in the JavaSEPort, I don't really understand the relation between the DefaultPixelMilliRatio, the ScreenResolution() and the retinaScale. Do tk.getScreenResolution() not return the screen resolution in dots per inch? if yes, why is it multiplied by the retinaScale to be transformed into DefaultPixelMilliRatio? is this retinaScale really needed? If I look at the IOSImplementation for example, the density for retina devices is directly computed into DIPs and there is no further need to know if a device is a retina one or not. - In IOSImplementation, is it possible to access the systemInfo.machine platform variable? If so, how? This would allow to better estimate the screen density that relying on rules on the screen resolution (that do not allow to identify iPad Mini gen 2 to 4 from other iPads): https://stackoverflow.com/questions/11197509/how-to-get-device-make-and-model-on-ios
On Tuesday, May 15, 2018 at 7:15:32 AM UTC+2, Shai Almog wrote: > > You can't make that change because it will break binary compatibility. > Constants in Java are linked into the class file so if you change their > value you will break the compilation. > -- You received this message because you are subscribed to the Google Groups "CodenameOne Discussions" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. Visit this group at https://groups.google.com/group/codenameone-discussions. To view this discussion on the web visit https://groups.google.com/d/msgid/codenameone-discussions/9fcc931b-8547-49e2-8a9e-baf650a6f8ea%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
