I have committed an alternate fix for this issue that will be available in the next update on Friday. I commented in the pull request with more detail on this change.
Steve On Sat, Jan 2, 2021 at 1:56 AM Marisole Aromatherapy <[email protected]> wrote: > No worries, hope it can be reviewed soon. If there is any issue let me > know. > > Thank you > > Javier > > > > On Sat, 2 Jan 2021, 06:15 Shai Almog, <[email protected]> wrote: > >> Hi, >> Sorry about that. >> Steve has an issue with the approach taken by that PR. I'll ask him to >> communicate that again when he gets back from vacation. >> >> On Friday, January 1, 2021 at 5:04:05 PM UTC+2 [email protected] wrote: >> >>> Hi all, happy new year 2021 >>> >>> 1 month ago, I submitted the following PR to allow clearing TextFields >>> on Android without needing to close and re-open the native keyboard. This >>> is a common feature of chat screens where when the "send" button is pressed >>> the user needs to keep typing subsequent messages without seeing the >>> keyboard fly up and down the screen >>> >>> https://github.com/codenameone/CodenameOne/pull/3319 >>> >>> I have delayed my work as much as possible, but I'm now reaching a point >>> where I have to package a version and publish. This feature is a crucial >>> part of it >>> >>> The PR originally consisted of a 1-line change in the native Android >>> port that would allow this functionality via a native call >>> >>> I was asked to expand the PR to expose this new functionality as a >>> general feature of non-native CN1. I included that in the PR >>> >>> Can one of the following actions be taken some time soon? >>> >>> 1- Review and approve full PR >>> 2- Approve the 1-line change >>> >>> Thanks in advance >>> >>> Javier >>> >> -- >> You received this message because you are subscribed to the Google Groups >> "CodenameOne Discussions" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/codenameone-discussions/281af64b-acdb-487e-aabc-a1052c29bd7en%40googlegroups.com >> <https://groups.google.com/d/msgid/codenameone-discussions/281af64b-acdb-487e-aabc-a1052c29bd7en%40googlegroups.com?utm_medium=email&utm_source=footer> >> . >> > -- > You received this message because you are subscribed to the Google Groups > "CodenameOne Discussions" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/codenameone-discussions/CAG90yJ0Z5N2CwHce7H6yw_69PEevE3vSaXHK%3DyOnJyVFtAN%2Bzw%40mail.gmail.com > <https://groups.google.com/d/msgid/codenameone-discussions/CAG90yJ0Z5N2CwHce7H6yw_69PEevE3vSaXHK%3DyOnJyVFtAN%2Bzw%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- Steve Hannah Software Developer Codename One http://www.codenameone.com -- You received this message because you are subscribed to the Google Groups "CodenameOne Discussions" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/codenameone-discussions/CAGOYrKXyFuN%3DUNdBMJc6N4yQ%2BKG8dm6KE3ic4TiFN%3D1jkLJXsw%40mail.gmail.com.
