>     After crashing the server a couple of times, I have found
>     that increasing the send-/user-/servbuf-sizes in send.[ch]
>     from 2048 to 8192 seems to make it work.  I'm not sure
>     whether dbuf.c's DBUF_SIZE needs to be increased as well.
>     Your guidance on this issue is appreciated.

dbuf.c probably does not need to be increased; more buffers will be
allocated as needed.  Ideally, the size of each dbuf structure should
be the size of a page minus malloc() overhead, but I'm not certain
that that's an optimization we need to be too concerned about.

>     I'm appending a patch for centralizing the sendbuffer-related
>     settings.

Our basic rules for posting of patches is that patches are posted
to patches@ only, and that discussion is held on coder-com@.  Also,
I would like to request that when you post the patches, you post
them in plain text, rather than BASE64-encoded; this not only allows
those of us using plain text mail browsers to view the message
in-line, it also allows us to quote specific sections of your patch
if we wish to make comments.

Your patch looks good; I can't foresee any problems, and it certainly
makes the source more maintainable.  Note, however, that in our
development tree, we've managed to eliminate sendbuf and the related
constant that you have named SENDBUFSIZE.  There are several places
where the magic numbers "510" and "512" are used, however, and we'll
look at correcting those.  Thank you!
-- 
Kevin L. Mitchell <[EMAIL PROTECTED]>

Reply via email to