> I made this patch which allows Channel Mode +O (Only Opers can join)
> This can be overrided by /inviting the user to the channel
Hi. I'm afraid there are several problems with this patch, just on the
technical level...
First, there's submission: Patches need to be submitted to
[EMAIL PROTECTED], not [EMAIL PROTECTED]'re trying to keep
huge emails off coder-com. Second, patches need to be posted in plain
text--a file inclusion rather than an attachment is really what I prefer.
Third, the patch itself is in context (usually generated by using the -c
switch to diff or cvs diff)--we tend to prefer patches in unified format
(-u), since it's much more compact.
Now on to more technical issues: You #define MODE_OPERONLY to be 0x1600.
This value is, in binary: 0001 0110 0000 0000--in other words, setting
this flag is equivalent to setting MODE_BAN and MODE_LIMIT. Fortunately,
as far as I know, 0x1000 is not yet used as a channel flag. You probably
want to change that '6' to be a '0'.
Second, near line 1017 of the new channel.c file, you use "//" as a
comment introducer. Although gcc permits this, and although it is
standard for C++, it has only recently been added to the C standard, and
most C compilers do not yet support it. You should either remove the
line entirely (preferred), or use C-style comments ("/* */").
I can't guarentee that we'll accept the final patch, once you've corrected
the issues mentioned above. Still, I have heard Undernet IRC operators
express interest in such a feature, so I personally am not opposed to it.
One other question--have you checked to see what other networks may define
channel mode +O and what semantics they give it? We prefer to try to
keep at least some user-visible features consistent across networks...
--
Kevin L. Mitchell <[EMAIL PROTECTED]>
