> While implementing apass1-2, my eye fell on m_create. > It seems that what happens there should be changed. > > Firstly, the last exit_client KILLs sptr, a client. It doesn't SQUIT > the server of sptr. But changing this into squitting the server of > sptr would be at least as wrong - consider: > > A <-- 5 minutes lag --> B - C - D - E - F - G > \- H - I - J > > Where 'A' is a laggy server that just got connected. > Now a client on the other side of the well-working network > (on 'G' say) creates a new channel. Its CREATE is forwarded > to F, E, and so on. > > When the CREATE reaches A, server A will KILL the client on G, > or SQUIT 'G' according to the comment in the code. > That can't be right. It should at _most_ SQUIT B. >
In this case it will not squit. It checks to see if the timestamp is more than 5 minutes in the *future* not the past, so lag will only make the test *less* likely to succeed. -- Hope that the day after you die is a nice day.
