Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1382#discussion_r160475533
--- Diff: core/conn/odbc/src/odbc/nsksrvr/SrvrConnect.cpp ---
@@ -6286,7 +6286,7 @@ bool GetHashInfo(char* sqlString, char*
genRequestError, char* HashTableInfo)
ControlQueryLen = ControlQueryLen + 4;
break;
case 6:
- sprintf(ControlQuery,"select cast(cast((52 *
1024 * 128) / (sum(co.column_size)) as integer) as varchar(10) character set
ISO88591) from %s.SYSTEM_SCHEMA.SCHEMATA sc, NEO.HP_DEFINITION_SCHEMA.OBJECTS
ob, NEO.HP_DEFINITION_SCHEMA.COLS co where sc.SCHEMA_NAME = '%s' and
ob.OBJECT_NAME = '%s' and sc.SCHEMA_UID = ob.SCHEMA_UID and ob.OBJECT_UID =
co.OBJECT_UID and ob.OBJECT_TYPE = 'BT' FOR READ UNCOMMITTED ACCESS",
srvrGlobal->SystemCatalog, verBuffer, verBuffer, atol(verBuffer), schemaToken,
tableName);
+ sprintf(ControlQuery,"select cast(cast((52 *
1024 * 128) / (sum(co.column_size)) as integer) as varchar(10) character set
ISO88591) from %s.SYSTEM_SCHEMA.SCHEMATA sc, NEO.HP_DEFINITION_SCHEMA.OBJECTS
ob, NEO.HP_DEFINITION_SCHEMA.COLS co where sc.SCHEMA_NAME = '%s' and
ob.OBJECT_NAME = '%s' and sc.SCHEMA_UID = ob.SCHEMA_UID and ob.OBJECT_UID =
co.OBJECT_UID and ob.OBJECT_TYPE = 'BT' FOR READ UNCOMMITTED ACCESS",
srvrGlobal->SystemCatalog, schemaToken, tableName);
--- End diff --
This fix is fine, but I think this code is dead code. The
NEO.HP_DEFINITION_SCHEMA stuff is all from a predecessor product. @hegdean,
@arvind-narain , should this code simply be deleted?
---
