Github user zellerh commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1413#discussion_r163950816
  
    --- Diff: install/traf_checkset_env.sh ---
    @@ -244,11 +244,14 @@ if [ ! -d ${javapath} ]; then
          exit 1
     fi
     
    +source $HOME/.bashrc
    --- End diff --
    
    Sourcing ~/.bashrc and looking into this file is not a very good solution, 
IMHO. There are so many other ways we can set JAVA_HOME. For example: 
/etc/bashrc, ~/.trafodion, $TRAF_HOME/.sqenvcom.sh.
    
    I would suggest to just check whether JAVA_HOME is set, otherwise duplicate 
the code in $TRAF_HOME/.sqenvcom.sh that sets JAVA_HOME. If JAVA_HOME is not 
already set, then you can then add a line 
    
    export JAVA_HOME=...
    
    To the file ~/.trafodion.


---

Reply via email to