Github user sureshsubbiah commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1417#discussion_r167464842
--- Diff: core/sql/executor/SequenceFileReader.h ---
@@ -199,15 +185,6 @@ class SequenceFileWriter : public JavaObjectInterface
// Close the file.
SFW_RetCode close();
-
- SFW_RetCode hdfsCreate(const char* path, NABoolean compress);
- SFW_RetCode hdfsWrite(const char* data, Int64 size);
- SFW_RetCode hdfsMergeFiles(const NAString& srcPath,
- const NAString& dstPath);
- SFW_RetCode hdfsDeletePath(const NAString& delPath);
- SFW_RetCode hdfsCleanUnloadPath(const NAString& uldPath );
- SFW_RetCode hdfsExists(const NAString& uldPath, NABoolean & exists );
- SFW_RetCode hdfsClose();
SFW_RetCode release();
virtual char* getErrorText(SFW_RetCode errEnum);
--- End diff --
Should this be static instead of virtual?
---