[GitHub] trafodion pull request #1504: [TRAFODION-3009] Streamline error handling in ...

[zellerh]

Github user zellerh commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1504#discussion_r178940492
  
    --- Diff: core/sql/executor/ExExeUtilCommon.cpp ---
    @@ -669,7 +669,9 @@ short ExExeUtilTcb::executeQuery(char * task,
            char * stringParam1 = NULL;
            Lng32   intParam1 = ComDiags_UnInitialized_Int;
     
    -       retcode = 
(short)cliInterface()->retrieveSQLDiagnostics(getDiagsArea());
    +            
setDiagsArea(cliInterface()->allocAndRetrieveSQLDiagnostics(getDiagsArea()));
    +            if (getDiagsArea() != NULL)
    +           retcode = 0;
    --- End diff --
    
    Thanks for the explanation.


---