Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1502#discussion_r179540660
  
    --- Diff: core/sql/common/NAType.h ---
    @@ -562,7 +562,8 @@ class NAType : public NABasicObject
                                 short displayCaseSpecific = 0);
     
       short getMyTypeAsText(NAString * outputStr, 
    -                   NABoolean addNullability = TRUE) const; // output
    +                   NABoolean addNullability = TRUE,
    +                        NABoolean addCollation = TRUE) const; // output
    --- End diff --
    
    Looks like the "// output" comment migrated to the wrong place. Maybe it 
belongs on "NAString * outputStr"? Or we could just delete it.


---

Reply via email to