Github user mashengchen commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1505#discussion_r179932150
--- Diff:
core/conn/jdbc_type2/src/main/java/org/apache/trafodion/jdbc/t2/SQLMXDesc.java
---
@@ -424,7 +424,7 @@ void checkValidNumericConversion(Locale locale) throws
SQLException
public static final int SQLCHARSETCODE_GB2312 = 17;
public static final String SQLCHARSETSTRING_UNKNOWN = "UNKNOWN";
- public static final String SQLCHARSETSTRING_ISO88591 = "ISO88591";
+ public static final String SQLCHARSETSTRING_ISO88591 = "ISO-8859-1";
--- End diff --
this is only used in java code for character encoding, see
SQLMXPreparedStatement.java:1981 which changed this time.
this variable is never used or passed to SQL engine
---