GitHub user robertamarton opened a pull request:

    https://github.com/apache/trafodion/pull/1516

    [TRAFODION-2205] invalid char at create schema when authorization nam…

    …e is long
    
    There is code that converts the user ID to its username.  The buffer size
    requested was not big enough to hold the return value.  In addition, the 
buffer
    size check was returning an error but did not add an error to the ComDiags 
area;
    therefore the returned error was ignored.
    - Changed max len in calls to getAuthNameFromAuthID to the correct size.
    - Set up the Diags area when buffer size is too small so the error is 
reported
      correctly.
    
    Also removed redundant methods:
    -  getDBUserNameFromID - calls getAuthNameFromID instead
    -  getDBUserIDFromName - calls GetAuthIDFromName instead

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/robertamarton/incubator-trafodion stuff

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafodion/pull/1516.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1516
    
----
commit affe1f60ff02610d40a9d58702b12d9c9473de34
Author: Roberta Marton <roberta.marton@...>
Date:   2018-04-12T16:07:02Z

    [TRAFODION-2205] invalid char at create schema when authorization name is 
long
    
    There is code that converts the user ID to its username.  The buffer size
    requested was not big enough to hold the return value.  In addition, the 
buffer
    size check was returning an error but did not add an error to the ComDiags 
area;
    therefore the returned error was ignored.
    - Changed max len in calls to getAuthNameFromAuthID to the correct size.
    - Set up the Diags area when buffer size is too small so the error is 
reported
      correctly, returns error 20235:
    
    "Error returned while converting auth ID to auth name, status: xx ID: xx."
    
    Also removed redundant methods:
    -  getDBUserNameFromID - calls getAuthNameFromID instead
    -  getDBUserIDFromName - calls GetAuthIDFromName instead

----


---

Reply via email to