Github user zellerh commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1557#discussion_r187148109
  
    --- Diff: core/sql/executor/ExHdfsScan.cpp ---
    @@ -569,6 +569,7 @@ ExWorkProcRetcode ExHdfsScanTcb::work()
                     break;
                  } 
                  hdfsScan_ = HdfsScan::newInstance((NAHeap *)getHeap(), 
hdfsScanBuf_, hdfsScanBufMaxSize_, 
    +                            hdfsScanTdb().hdfsIoByteArraySize_, 
    --- End diff --
    
    The parameter is a short, but we are passing an unsigned short here, would 
be better to make them both a short (see also more comments above about using a 
16 bit variable for size in KB).


---

Reply via email to