Github user xiaozhongwang commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1562#discussion_r187841031
  
    --- Diff: core/sqf/src/tm/tmtransaction.cpp ---
    @@ -797,7 +797,7 @@ short TM_Transaction::status(short *pp_status)
             return iv_last_error;
         }
     
    -    if (!gv_tmlib.is_initialized())
    +    if (!gv_tmlib_initialized)
    --- End diff --
    
    There are a lot of same code place as this:
        if (!gv_tmlib_initialized)
             gv_tmlib.initialize();
    I think it's better to add a method to do the same thing. but some of the 
places are in order to performance. just a suggestion.


---

Reply via email to