Github user zellerh commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1593#discussion_r193218463
  
    --- Diff: core/sqf/sql/scripts/install_local_hadoop ---
    @@ -726,21 +726,27 @@ else
       if [ $? -ne 0 ]; then
         (${JAVA_EXE} -version 2>&1) | grep '1.7' >/dev/null
         if [ $? -ne 0 ]; then
    -      echo '**** ERROR:'
    -      cat <<EOF
    -      Please make sure you are using the Java 1.6 or 1.7 SDK.
    -      Otherwise, download it into ${MY_SW_ROOT}, extract it and
    -      make a symbolic link ${MY_SW_ROOT}/java that points  to it and
    -      export JAVA_HOME=${MY_SW_ROOT}/java
    +      (${JAVA_EXE} -version 2>&1) | grep '1.8' >/dev/null
    +      if [ $? -ne 0 ]; then
    +        echo '**** ERROR:'
    +        cat <<EOF
    +        Please make sure you are using the Java 1.6 or 1.7 SDK.
    --- End diff --
    
    Minor comment: This should say 1.7 or 1.8 SDK.


---

Reply via email to