Github user zellerh commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1623#discussion_r198552129
  
    --- Diff: core/sql/cli/CliExpExchange.cpp ---
    @@ -3804,7 +3893,10 @@ InputOutputExpr::inputValues(atp_struct *atp,
               if (!source) {
            continue;
          }
    -
    +          if(isOdbc)
    --- End diff --
    
    I wonder whether it is correct that JDBC passses a string of the format 
_iso88591'ABCD' here. I would have expected that trafci should have already 
converted this to an unquoted string. You can try the following with your fix 
and see what you get:
    
    trafci
    execute xx using '_iso88591''ABCD''';
    
    Will this insert ABCD into the table or _iso88591'ABCD'? If it inserts 
ABCD, then I think the real bug is in trafci, not in this method, 
InputOutputExpr::inputValues().


---

Reply via email to