Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1622#discussion_r199649187
  
    --- Diff: core/sql/parser/sqlparser.y ---
    @@ -500,6 +501,7 @@ static void enableMakeQuotedStringISO88591Mechanism()
     %token <tokval> TOK_CARDINALITY
     %token <tokval> TOK_CASE
     %token <tokval> TOK_CAST
    +%token <tokval> TOK_CENTURY
    --- End diff --
    
    The new tokens, TOK_CENTURY, TOK_DECADE, etc., need to be added to the 
nonreserved_word production, otherwise they will be taken as reserved words 
(notwithstanding the NONRESTOKEN_ flag in ParKeyWords.cpp). Please also add 
them to test core/TEST037, which tests that non-reserved words really are 
non-reserved.


---

Reply via email to