Github user traflm commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1646#discussion_r202908302
--- Diff: core/sql/sqlcomp/CmpSeabaseDDLcommon.cpp ---
@@ -10991,7 +10997,20 @@
CmpSeabaseDDL::setupHbaseOptions(ElemDDLHbaseOptions * hbaseOptionsClause,
hbaseOptionsStr += optionStr;
}
}
+ if (!flushSize.isNull() && !memstoreFlushSizeOptionSpecified)
+ {
+ hbaseOption = new(STMTHEAP) HbaseCreateOption("MEMSTORE_FLUSH_SIZE",
+ flushSize.data());
+ hbaseCreateOptions.insert(hbaseOption);
+ if (ActiveSchemaDB()->getDefaults().userDefault
+ (HBASE_MEMSTORE_FLUSH_SIZE_OPTION) == TRUE)
+ {
+ numHbaseOptions += 1;
+ sprintf(optionStr, "MEMSTORE_FLUSH_SIZE='%s'|",
flushSize.data());
--- End diff --
I agree, I can change this into a more robust coding style, using snprintf.
---
