Github user xiaozhongwang commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1671#discussion_r206444234
--- Diff: core/conn/odb/src/odb.c ---
@@ -40,6 +40,7 @@ char *odbauth = "Trafodion Dev
<[email protected]>";
#define MAX_ARGS 11 /* Max arguments for interactive mode */
#define ARG_LENGTH 128 /* Max argument length in interactive mode
*/
#define LINE_CHUNK 51200 /* size of memory chunks allocated to
store lines */
+#define ERR_MSG_LEN 512 /* size of error message buffer */
--- End diff --
The value of short is [32768, 32767], why do you define it so small?
I am worried that this value is too small and will cause a buffer overflow.
---
