Github user sureshsubbiah commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1674#discussion_r207442360
--- Diff: core/sql/executor/ExHdfsScan.cpp ---
@@ -571,6 +569,7 @@ ExWorkProcRetcode ExHdfsScanTcb::work()
hdfsScan_ = HdfsScan::newInstance((NAHeap *)getHeap(),
hdfsScanBuf_, hdfsScanBufMaxSize_,
hdfsScanTdb().hdfsIoByteArraySizeInKB_,
&hdfsFileInfoListAsArray_, beginRangeNum_,
numRanges_, hdfsScanTdb().rangeTailIOSize_,
+ isSequenceFile(),
hdfsScanTdb().recordDelimiter_,
--- End diff --
If we did not pass in the recordDelimiter_ previously, do we know if
previous code worked correctly for text format, when the record delimiter was
something other than /n ? This PR does not seem change anything for text format
reads, so if there was issue previously, it might still exist.
---
