Github user arvind-narain commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1685#discussion_r208368992
--- Diff: core/sql/common/IpcGuardian.cpp ---
@@ -4135,13 +4131,9 @@ void IpcGuardianServer::useProcess(ComDiagsArea
**diags,
short i = 0;
while (i < 3)
{
- short gprc = 0;
- procHandle = get_phandle_with_retry(tmpProcessName, &gprc);
- if (procHandle != NULL)
- rc = 0;
- else
- rc = gprc;
- if ((rc != 0) || (procHandle == NULL))
+ int gprc = 0;
+ gprc = get_phandle_with_retry(tmpProcessName, &procHandle);
+ if (rc != FEOK)
--- End diff --
Should rc be set first or use gprc ?
---
