[GitHub] trafodion pull request #1699: [TRAFODION-2404] enhance the regexpr performan...

[traflm]

Github user traflm commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1699#discussion_r211479574
  
    --- Diff: core/sql/exp/exp_like.cpp ---
    @@ -513,11 +512,16 @@ ex_expr::exp_return_type 
ExRegexpClauseChar::eval(char *op_data[],
     
       str_cpy_all(pattern, op_data[2], len2);
       str_cpy_all(srcStr, op_data[1], len1);
    -
    -  z = regcomp(&reg, pattern, cflags);
    +  if(rpattern_ != pattern)
    --- End diff --
    
    Hi, Dave, rpattern_ is NAString, so I think this comparison is correct? My 
intent is to compare the content.
    Let me check the NAString further.


---