Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1723#discussion_r225659935
--- Diff: core/sql/common/ComSecurityKey.cpp ---
@@ -191,33 +216,41 @@ bool buildSecurityKeys( const int32_t userID,
return false;
}
- // If the grantee is a role, generate a special security key
- // If the role is revoked from the user, this key takes affect
+ // If the grantee is a role, generate special security keys, one for
+ // the user and one for each of the user's roles.
+ // If the role is revoked from the user these key takes affect
if (PrivMgr::isRoleID(granteeID))
{
- ComSecurityKey key (userID, granteeID,
ComSecurityKey::SUBJECT_IS_USER);
- if (doDebug)
+ char buf [200];
--- End diff --
This variable isn't used anywhere. Maybe we should delete it?
---
