Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1739#discussion_r231655749
  
    --- Diff: core/conn/odb/src/odb.c ---
    @@ -10183,6 +10183,7 @@ static int Oloadbuff(int eid)
                     }
                     Oi++;
                 }
    +            Oi = 1; //the record number need to be initialize for next loop
    --- End diff --
    
    This is fine, but it might be a bit clearer to the reader if the 
initialization was at the beginning of the loop, for example at line 10090.


---

Reply via email to