Github user Guo-Heng commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1748#discussion_r236030287
--- Diff: core/sqf/src/tm/tm.cpp ---
@@ -2789,7 +2789,7 @@ void tm_process_msg(BMS_SRE *pp_sre)
{
short lv_ret;
char la_send_buffer[4096];
- char la_recv_buffer[sizeof(Tm_Req_Msg_Type)];
+ char la_recv_buffer[pp_sre->sre_reqDataSize];
--- End diff --
I'm sorry, Dave, it's my fault, I found the problem which I discribed in
the JIRA#3236 in EsgynDB, after I compared to the Tafodion of this code block,
my real purpose is to get rid of the dynamic allocation of la_recv_buffer_ddl
and use la_recv_buffer, which needs to eliminate the following 2808 line if
branch, and the other la_recv_buffer_ddl code used below, but I think I
accidentally uploaded an incomplete version, I will rollback this bug version
and submit the complete edit. In addition, the content described by JIRA#3236
is not suitable, because this is not an error in Trafodion, but a code
optimization improvement, I will also modify it.
---
