Github user prashanth-vasudev commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1749#discussion_r236393855
--- Diff: core/sqf/src/tm/tm.cpp ---
@@ -2789,8 +2789,7 @@ void tm_process_msg(BMS_SRE *pp_sre)
{
short lv_ret;
char la_send_buffer[4096];
- char la_recv_buffer[sizeof(Tm_Req_Msg_Type)];
- char *la_recv_buffer_ddl = NULL;
+ char la_recv_buffer[pp_sre->sre_reqDataSize];
--- End diff --
Would be good to check the size for non zero value. If the caller passes
zero, process will crash at a later point.
---
