Github user Weixin-Xu commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1750#discussion_r237327092
  
    --- Diff: win-odbc64/security_dll/native/source/secpwd.cpp ---
    @@ -217,8 +221,25 @@ SecPwd::SecPwd(const char *dir, const char* fileName,
         if(stat(certDir,&st) != 0)
             throw SecurityException(DIR_NOTFOUND, (char *)certDir);
     
    -    certFile = buildName(certDir, fileName, serverName, CER);
    -    activeCertFile = buildName(certDir, activeFileName, serverName, 
ACTIVE_CER);
    +    if (lcid == 0x804) // if local charset is not utf8
    --- End diff --
    
    I will change "is not utf8" to "is gbk". Do you know how many character 
sets we need?


---

Reply via email to