DaveBirdsall opened a new pull request #1831: [TRAFODION-3300] Fix overflow issues with extreme big nums + ROUND URL: https://github.com/apache/trafodion/pull/1831 This set of changes does the following: 1. Implements the ROUND function for BIG NUM data types (e.g. NUMERIC(n,m) where n > 18) in the expression evaluator. Formerly, the binder would rewrite ROUND as a rather complicated series of other functions, which unfortunately cause overflows in extreme cases. 2. Adds extensive white box tests to the regression library for the new ROUND implementation. 3. Adds error message 4054 to cover the case where a user specifies ROUND(A,m) where m is larger than the maximum precision allowed for the data type. Formerly, we would give an incorrect error in this case. 4. Add method NAType::display to make it easier for developers to view NAType information when debugging the compiler. 5. As a test aid, I left the old code in. If CQD COMP_BOOL_15 is set to 'OFF', we use the old code. If it is 'ON' we use the new code. The default is 'ON'. It is intended that a future JIRA will remove this CQD and remove the old code, once the new code has sufficient exposure.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
