DaveBirdsall opened a new pull request #1840: [TRAFODION-3308] Improve error reporting when a process cannot be started URL: https://github.com/apache/trafodion/pull/1840 This pull request contains improvements to error reporting when a process server cannot be started. The following changes are made: 1. Logic in the compiler (optimizer/NodeMap.cpp) to compute node names has been corrected. Thanks to @sandhyasun for this change. 2. The correct node name is now reported in error messages 2012 and 2013 (common/IpcGuardian.cpp). Formerly, a hard-coded value of "NSK" was reported. 3. Redundant 2013 and 2002 error messages are no longer generated (common/IpcGuardian.cpp and cli/ExSqlComp.cpp). 4. Interpretive text has been added to error 2012 to give a more human-understandable reason behind certain common error codes (common/IpcGuardian.cpp and bin/SqlciErrors.txt). 5. The nodeName_ member in IpcGuardianServer is now computed at run time, and only if needed (common/IpcGuardian.cpp). (This happens during error reporting only.) This is done because the compile time value may be different in the case of ESPs due to node down conditions. Former logic that put "NSK" in this field has been removed. 6. The function ComRtGetOSClusterName is an obsolete function that in predecessor products returned the cluster name. On Trafodion, it just returns the string "NSK". I removed much but not all of the logic that calls this function. This resulted in the removal of some dead code (executor/ExCancel.cpp, executor/ExExeUtilCommon.cpp). 7. The method IpcServerClass::getProcessName required the node name in predecessor products but does not in Trafodion. I removed the node name and node name length parameters from this method and associated code (common/Ipc.cpp). I was motivated to do this because the old calling code sometimes took strlen(nodeName_) to get the node name length, but due to the changes above nodeName_ is now null in some cases.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
