selvaganesang commented on issue #1842: [TRAFODION-3310] Commit transaction needs to be complete before returning to the caller. URL: https://github.com/apache/trafodion/pull/1842#issuecomment-494923702 > +1 Looks good to me. Looks like the primary change is to remove the predecessor concept of "DP2 transaction", and also to allow the CLI to not wait for transaction commit if the environment variable DTM_EARLYCOMMITREPLY is defined and non-zero. Is that correct? Yes. It is no good to use the passed in parameter to commitTransaction method to determine if the commit needs to be waited or not. It is important that commit completes before caller gets the control to ensure data consistency
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
