DaveBirdsall commented on a change in pull request #1848: [TRAFODION-3316] 
Three fixes to UPDATE STATISTICS
URL: https://github.com/apache/trafodion/pull/1848#discussion_r301757542
 
 

 ##########
 File path: core/sql/ustat/hs_globals.cpp
 ##########
 @@ -4392,6 +4388,12 @@ Lng32 HSSample::make(NABoolean rowCountIsEstimate, // 
input
         LM->Log(LM->msg);
       }
 
+ 
+    double sampleRatio = samplePercent / 100;
 
 Review comment:
   I tried this, actually. We get "infinity" for the floating point number. 
That's why I added the "isnormal" test. We also error out with a 9207 error if 
the sample table is empty.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to