Github user selvaganesang commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/5#discussion_r33215262
  
    --- Diff: core/conn/jdbc_type2/native/Debug.cpp ---
    @@ -183,8 +184,9 @@ static const char *UCase(const char *text)
     
     static unsigned long GetThreadId(void)
     {
    -   _TSLX_t thread_id = tslx_ext_pthread_self();
    -   return((unsigned long) thread_id.field1);
    +   //_TSLX_t thread_id = tslx_ext_pthread_self();
    +   //return((unsigned long) thread_id.field1);
    +        return pthread_self();
    --- End diff --
    
    Consider removing TSLX thread and pthread package references in T2 driver. 
T2 driver may not need to deal with threads at all. Also consider using 
syscall(SYS_gettid); to get the thread id to avoid pulling in pthread 
references.
    
    You should feel free to drop all wanted cpp and .h files related to threads


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to