Github user sureshsubbiah commented on the pull request:
https://github.com/apache/incubator-trafodion/commit/ac80fbdbfb8a459b75b23fa992512f62370c03f2#commitcomment-12120838
Change looks great Selva.
What happens if the row is rather large and the
exe_memory_for_probe_cache_in_mb is set to a rather small value. The case where
the cqd value is less than the size of 1 row is interesting. We may need some
defensive code around the case where the cqd is set to a low value that we
don't have enough room for a valid sized up queue and down queue? I am not
sure, maybe current logic takes care of it. One possibility is to make sure
that probe cache will keep at least 4 rows (2 rows in up queue and 2 rows in
down queue).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
