Github user zellerh commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/37#discussion_r36137159
--- Diff: core/sql/optimizer/NAFileSet.h ---
@@ -72,6 +72,13 @@ enum FileOrganizationEnum
KEY_SEQUENCED_FILE,
HASH_FILE
};
+
+enum RowFormatEnum {
+ SQLMX_UNKNOWN_FORMAT,
+ SQLMX_ROW_FORMAT,
+ SQLMX_ALIGNED_ROW_FORMAT,
+ SQLMX_HBASE_FORMAT
--- End diff --
SQLMX_ALIGNED_ROW_FORMAT is already used in NATable.h for a flag. Should we
avoid this conflict (renaming either one). Also, I'm wondering whether this
should go into ComSmallDefs, since it is fairly fundamental.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
