Github user zellerh commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/52#discussion_r36817313
--- Diff: core/sql/exp/ExpHbaseInterface.cpp ---
@@ -1315,32 +1192,30 @@ Lng32 ExpHbaseInterface_JNI::checkAndInsertRow(
const int64_t timestamp,
NABoolean asyncOperation)
{
- HTableClient_JNI *htc = client_->getHTableClient((NAHeap *)heap_,
tblName.val, useTRex_, hbs_);
- if (htc == NULL) {
- retCode_ = HBC_ERROR_GET_HTC_EXCEPTION;
- return HBASE_OPEN_ERROR;
- }
-
- Int64 transID;
+ HTableClient_JNI *htc;
+ Int64 transID;
+ NABoolean checkAndPut = TRUE;
+
if (noXn)
- transID = 0;
- else
+ transID = 0;
+ else
transID = getTransactionIDFromContext();
-
+ retCode_ = client_->insertRow((NAHeap *)heap_, tblName.val, hbs_,
--- End diff --
Since the method is called checkAndInsertRow, should we not call
checkAndInsertRow here as well? Sorry, haven't looked yet at the surround what
really happens, but this could either be wrong or confusing - unless I'm wrong
or confused :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
