Github user robertamarton commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/62#discussion_r37681326
--- Diff: core/sql/sqlcomp/CmpSeabaseDDLcommon.cpp ---
@@ -3422,7 +3440,7 @@ Int64 CmpSeabaseDDL::getObjectUIDandOwners(
strcpy(cfvd, " and valid_def = 'Y' ");
char buf[4000];
--- End diff --
All the SQL requests generated by the DDL component use this method to
create strings on the fly. It is a good suggestion but we may want to consider
some generic method and change all the string creations to use this method. Do
we really have this much of a concern for stack overflow?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
