Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/66#discussion_r38105680
--- Diff: core/sql/generator/GenPreCode.cpp ---
@@ -170,12 +174,16 @@ static NABoolean processConstHBaseKeys(Generator *
generator,
skey->getIndexDesc()->getOrderOfKeyValues(),
relExpr->getGroupAttr()->getCharacteristicInputs(),
TRUE, /* forward scan */
- exePreds,
+ keyPreds,
nonKeyColumnSet,
idesc,
relExpr->getGroupAttr()->getCharacteristicOutputs(),
mySearchKeys);
+ // Include any remaining key predicates that have not been
+ // picked up (to be used as the HBase search keys).
+ exePreds += keyPreds;
--- End diff --
Not sure I understand the point of subtracting the keyPreds at line 169
then just adding them back here. The exePreds set is not passed to
HbaseSearchKey::makeHBaseSearchKeys.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
