Github user arvind-narain commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/121#discussion_r42017420
  
    --- Diff: 
core/conn/jdbc_type4/src/org/trafodion/jdbc/t4/TrafT4ResultSet.java ---
    @@ -4299,12 +4299,10 @@ private BaseRow getCurrentRow() throws SQLException 
{
                        return insertRow_;
                } else {
                        if (isBeforeFirst_) {
    -                           String cursorExpt = "The cursor is before the 
first row, therefore no data can be retrieved.";
    -                           throw 
HPT4Messages.createSQLException(connection_.props_, connection_.getLocale(), 
cursorExpt, null);
    +                           throw 
HPT4Messages.createSQLException(connection_.props_, connection_.getLocale(), 
"cursor_is_before_first_row", null);
    --- End diff --
    
    Hi Dave - change in pr 120 is with the message filename itself.
    
    createSQLException takes in the string supplied and appends "_msg", 
"_sqlstate", "_sqlcode" to get the corresponding message, state and error code 
from the message file (now T4Messages)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to