Github user nonstop-qfchen commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/132#discussion_r42406933
--- Diff: core/sql/optimizer/ItemExpr.cpp ---
@@ -14906,3 +14906,80 @@ NABoolean LOBoper::isCovered
return FALSE;
}
+// Compute the exprssion at compile time. Assume all operands are
constants.
+// Return NULL if the computation fails and CmpCommon::diags() may be
side-affected.
+ConstValue* ItemExpr::compute(CollHeap* heap)
--- End diff --
Maybe rename it as evaluateToConsValue()?
On Mon, Oct 19, 2015 at 1:01 PM, DaveBirdsall <[email protected]>
wrote:
> In core/sql/optimizer/ItemExpr.cpp
>
<https://github.com/apache/incubator-trafodion/pull/132#discussion_r42404401>
> :
>
> > @@ -14906,3 +14906,80 @@ NABoolean LOBoper::isCovered
> > return FALSE;
> > }
> >
> > +// Compute the exprssion at compile time. Assume all operands are
constants.
> > +// Return NULL if the computation fails and CmpCommon::diags() may be
side-affected.
> > +ConstValue* ItemExpr::compute(CollHeap* heap)
>
> I'm slightly confused about what this function is for. The comments and
> the name ("compute") suggest that it is for evaluation of arbitrary
> constant expressions, but the comments and variable names inside the
> function make reference to decoding and keys. But I'm guessing there is
> nothing in this function that is decoding-specific or key-specific. Is
that
> correct?
>
> â
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/incubator-trafodion/pull/132/files#r42404401>.
>
--
Regards, --Qifan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
