Github user selvaganesang commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/166#discussion_r44612720
--- Diff:
core/sqf/src/seatrans/hbase-trx/src/main/java/org/apache/hadoop/hbase/regionserver/transactional/SingleVersionDeleteNotSupported.java
---
@@ -53,13 +54,15 @@ public SingleVersionDeleteNotSupported() {
* mechansim will currently treat DeleteColumn the same as Delete
which could cause confusion.
*/
public static void validateDelete(final Delete delete) throws
SingleVersionDeleteNotSupported {
- Collection<List<KeyValue>> values = delete.getFamilyMap().values();
- for (List<KeyValue> value : values) {
- for (KeyValue kv : value) {
- if (Type.Delete.getCode() == kv.getType()) {
+ Collection<List<Cell>> values = delete.getFamilyCellMap().values();
+ for (List<Cell> value : values) {
+ for (Cell cell : value) {
+ KeyValue kv = new KeyValue(cell);
--- End diff --
Consider using cell.getTypeByte instead of constructing a new object kv
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
