Github user DaveBirdsall commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/174#discussion_r45080536
  
    --- Diff: core/sql/optimizer/OptPhysRelExpr.cpp ---
    @@ -3910,6 +3910,20 @@ InputPhysicalProperty* NestedJoin::generateIpp(
       InputPhysicalProperty* ipp = NULL;
     
       // ----------------------------------------------------------------
    +  // If there is a cardinality constraint on the outer child, we'll
    +  // pass that information along to the inner child.
    +  // ----------------------------------------------------------------
    +  Cardinality minRows;
    +  Cardinality maxRows;
    +  CardConstraint * outerCardinalityConstraint = NULL;
    +
    +  if (getGroupAttr()->hasCardConstraint(minRows, maxRows))
    --- End diff --
    
    Good catch... I think you are right. I will fix this. I wondered why my 
unit test succeeded with this mistake. It succeeded because both legs of the 
join had cardinality constraint of one so the join itself had this constraint 
also.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to