Github user selvaganesang commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/197#discussion_r47035342
  
    --- Diff: 
core/sqf/src/seatrans/hbase-trx/src/main/java/org/apache/hadoop/hbase/regionserver/transactional/TrxTransactionState.java
 ---
    @@ -126,15 +130,49 @@
            }
            catch (NoSuchMethodException exc_nsm2) {
                sb_sqm_98_4 = false;
    +                LOG.info("Got info of Class ScanQueryMatcher for HBase 
version" + VersionInfo.getVersion());
            }
        }
    -
        if (sb_sqm_98_1) {
            LOG.info("Got info of Class ScanQueryMatcher for HBase 98.1");
        }
        if (sb_sqm_98_4) {
            LOG.info("Got info of Class ScanQueryMatcher for HBase 98.4");
        }
    +   
    +   
    +   Class scaninfoClazz = null;
    --- End diff --
    
    I believe scaninfoclazz should also be made static. Can you please check if 
the scanInfoConstructor becomes invalid if scanInfoclazz gets gc-ed. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to