Github user eowhadi commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/255#discussion_r49227654
--- Diff: core/sql/executor/ExHbaseAccess.cpp ---
@@ -2808,53 +2808,51 @@ short ExHbaseAccessTcb::setupHbaseFilterPreds()
(hbaseAccessTdb().listOfHbaseFilterColNames()->numEntries() == 0))
return 0;
- if (! hbaseFilterValExpr())
- return 0;
-
- ex_queue_entry *pentry_down = qparent_.down->getHeadEntry();
-
- workAtp_->getTupp(hbaseAccessTdb().hbaseFilterValTuppIndex_)
- .setDataPointer(hbaseFilterValRow_);
-
- ex_expr::exp_return_type evalRetCode =
- hbaseFilterValExpr()->eval(pentry_down->getAtp(), workAtp_);
- if (evalRetCode == ex_expr::EXPR_ERROR)
- {
- return -1;
- }
-
- ExpTupleDesc * hfrTD =
- hbaseAccessTdb().workCriDesc_->getTupleDescriptor
- (hbaseAccessTdb().hbaseFilterValTuppIndex_);
-
- hbaseFilterValues_.clear();
- for (Lng32 i = 0; i < hfrTD->numAttrs(); i++)
- {
- Attributes * attr = hfrTD->getAttr(i);
-
- if (attr)
- {
- NAString value(getHeap());
- if (attr->getNullFlag())
- {
- char nullValChar = 0;
-
- short nullVal =
*(short*)&hbaseFilterValRow_[attr->getNullIndOffset()];
-
- if (nullVal)
- nullValChar = -1;
- value.append((char*)&nullValChar, sizeof(char));
- }
-
- char * colVal = &hbaseFilterValRow_[attr->getOffset()];
-
- value.append(colVal,
-
attr->getLength(&hbaseFilterValRow_[attr->getVCLenIndOffset()]));
-
- hbaseFilterValues_.insert(value);
- }
- }
-
+ if (hbaseFilterValExpr()){// with pushdown V2 it can be null if we have
only unary operation
--- End diff --
are you seeing the problem only on the new code, or was it already in the
old one? Because I do see bad indentation in one or 2 area, but that is old
code, nothing added?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
